Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically use Redshift 4.0 or 4.1 JDBC driver, depending on which is installed #90

Closed
wants to merge 2 commits into from
Closed

Automatically use Redshift 4.0 or 4.1 JDBC driver, depending on which is installed #90

wants to merge 2 commits into from

Conversation

JoshRosen
Copy link
Contributor

This patch refactors the driver-loading code so that it automatically uses either the Redshift JDBC 4.0 or 4.1 drivers, depending on which is installed. I also added support for automatically supplying an appropriate default JDBC driver class name when the postgres:// subprotocol is used.

I tested all of the error-handling corner-cases manually.

Fixes #83.

@JoshRosen JoshRosen added this to the 0.5.1 milestone Sep 15, 2015
@codecov-io
Copy link

Current coverage is 94.84%

Merging #90 into master will increase coverage by +0.03% as of 4835231

@@            master     #90   diff @@
======================================
  Files           11      11       
  Stmts          444     446     +2
  Branches       107     109     +2
  Methods          0       0       
======================================
+ Hit            421     423     +2
  Partial          0       0       
  Missed          23      23

Review entire Coverage Diff as of 4835231

Powered by Codecov. Updated on successful CI builds.

@marmbrus
Copy link
Contributor

LGTM

@JoshRosen JoshRosen closed this in 43f9709 Sep 15, 2015
@JoshRosen JoshRosen deleted the auto-configure-jdbc-driver-class branch September 15, 2015 20:07
@JoshRosen JoshRosen mentioned this pull request Sep 15, 2015
Closed
MasterDDT pushed a commit to ActionIQ-OSS/spark-redshift that referenced this pull request Aug 6, 2021
@jsleight
Merge pull request databricks#90 from spark-redshift-community/jsleig…
3cb8667 
…ht_remove_sbt_spark_package

Remove reliance on sbt-spark-package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshRosen @codecov-io @marmbrus